Implement POST /user, POST /login, JWT-based authorization
#31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Move class-related endpoints to /class. * Add docs to README.md. Co-authored-by: pkrish20 <preethask@g.ucla.edu> Co-authored-by: svetly-t <svetly-t@users.noreply.github.com>
krashanoff
added
backend
krashanoff
changed the title
POST /user, scaffold JWT-based authorizationPOST /user, POST /login, JWT-based authorization
* Add doc comments throughout. * Improve feedback for login failures, etc. * Reformat SQL queries for readability.
svetly-t
reviewed
Feb 7, 2022
backend/main.py
Outdated
| "-s", | ||
| "--secret", | ||
| type=str, | ||
| default="gradbetter", |
There was a problem hiding this comment.
Nit this was probably supposed to be "gradebetter".
svetly-t
approved these changes
Feb 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR, based on #30, implements the "create user" endpoint on the backend. Users can create an account in the backend database, and are returned a JSON Web Token, to be included in the
Authorizationheader of future transactions. It closes #22. It also adds thePOST /loginendpoint for users to log in, closing #20.The final change in this PR just changes the default RDBMS login string in our main function to reflect the variables used in our
Dockerfile.Its specification is outlined in our backend documentation as such:
POST /userLogin as an user, returning a JWT for future requests. Please please please only send this on TLS.
Request Body
{ "type": "professor", "username": "Smallberg", "password": "MYSECRETPASSWORD DONT TELL ANYONE LOL" }Response Format
{ "token": "SomeLongStringOfBase64" }POST /loginLogin as an user, returning a JWT for future requests. Please please please only
send this on TLS.
Request Body
{ "username": "Smallberg", "password": "MYSECRETPASSWORD DONT TELL ANYONE LOL" }Response Format
{ "token": "SomeLongStringOfBase64" }