Uploading code and a grading script #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…2/Group-A3 into cindyrzheng/upload-code
|
Cindy, could you rebase this on main? |
krashanoff
requested changes
Mar 2, 2022
tried addressing all the feedback! pls lmk if this is good! |
krashanoff
reviewed
Mar 3, 2022
Co-authored-by: leo <leo@krashanoff.com>
Co-authored-by: leo <leo@krashanoff.com>
…2/Group-A3 into cindyrzheng/upload-code
krashanoff
approved these changes
Mar 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still under construction since the APIs for uploading a file is still unimplemented. Need help also with the API request! Not sure what to send in the body!
Other than that- added context to be passed from the overall class view landing page to the specific assignment view, will need to probably build on that context later but it works as a start!
then also added modals for uploading student code and slightly changed the modal for uploading a grading script by adding controlled inputs so we can access all the inputs in the form. Also added the scaffold for the API request (it's totally wrong as of now but as long as I can get the body right, and some dummy class IDs and Assignment IDs we're good!).