generated from cs130-w22/template
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Krashanoff/websockets #65
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krashanoff
added
backend
Concerning the backend
documentation
Concerning documentation
labels
Mar 2, 2022
I looked this over and did not see any immediate issues with it. It looks good, I think. |
krashanoff
force-pushed
the
krashanoff/websockets
branch
from
March 2, 2022 14:32
b0a7700
to
a8b86aa
Compare
It's going to complain about how I'm not checking for |
boundaries. Start websocket endpoint.
krashanoff
force-pushed
the
krashanoff/websockets
branch
from
March 2, 2022 23:55
e1c57da
to
6daf550
Compare
Rebased on main. Basic functionality for websockets is there. Now just have to bind it to our frontend. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #63. Begins implementation of a websocket handler and most of the grading runner subsystem. Right now, it looks a little something like this:
Basically, SPMC parallelism over websockets. There's the issue of the server terminating before writing back results, right now, but I think that as long as this is well-documented, we can come back to it in the near future, before much more is built on the runner. The hierarchy looks like: