Edwardsabalburo/hookup assignment to backend #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to backend response
cindyrzheng
reviewed
Mar 3, 2022
| const params = useParams(); | ||
|
|
||
| fetch( | ||
| "http://localhost:8080/class/1/1", //"http://localhost:8080/class/${params.classId}/${params.assignmentId}", will change |
There was a problem hiding this comment.
Since @1strangequark's PR is out I would probably just change it to the comment and then quickly merge and approve @1strangequark 's PR before yours
cindyrzheng
reviewed
Mar 4, 2022
| }) | ||
| .then((resp) => { | ||
| const total = calculateTotalScore(resp.submissions); | ||
| // Mean and Median should be changed to work with assignment submissions for all class members |
There was a problem hiding this comment.
yeah seems like there's not a way to do this yet so this should work!
cindyrzheng
approved these changes
Mar 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding dynamic loading of statistics for assignment viewing. This essentially adds all the scaffolding necessary but currently runs on a single endpoint. Once the parameters are set up in the url, I can update the code again to reflect them. Also, the mean and median are only operating on a single user's submissions, but when a backend endpoint is created that returns all the submission JSON data, implementing the expected functionality should be straightforward.
All of the changes necessary to produce the final expected output is also marked with comments in the code.