Old Seashell (v3) Updates: #842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
yc2lee
commented
Nov 23, 2017
yc2lee
commented
- Hack around issue Memory leak not reported #836 by using clang executable, which finds the memory leak properly. I gave up trying to diagnose the Seashell wrapper.
- Log out button should go back to Seashell sign-in page instead of CAS
- Update sign-in page with supported browsers and better "wrong password" message
- Disable offline mode
* Hack around issue cs136#836 by using clang executable, which finds the memory leak properly * Log out button should go back to Seashell sign-in page instead of CAS * Update sign-in page with supported browsers and better "wrong password" message * Disable offline mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.