Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invitation workflow for OCM, take 2 #54

Merged
merged 17 commits into from
Dec 9, 2022

Conversation

glpatcern
Copy link
Member

This PR supersedes #41.

I have rebased the new endpoints on top of the current develop branch. We should have a discussion with @michielbdejong as a main contributor in this repo also to address the yet outstanding comments from the previous PR, so this is still WIP though Reva currently includes a full implementation of these specs.

@glpatcern glpatcern self-assigned this Jun 21, 2022
@glpatcern glpatcern marked this pull request as draft June 21, 2022 15:11
@michielbdejong
Copy link
Contributor

@glpatcern great, let's have a video call to walk through the details!

@glpatcern glpatcern force-pushed the add-invite-accept branch from 6780049 to f3b2330 Compare June 22, 2022 15:25
Copy link
Member Author

@glpatcern glpatcern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Self-reviewing for further brainstorming)

spec.yaml Outdated Show resolved Hide resolved
spec.yaml Outdated Show resolved Hide resolved
@smesterheide
Copy link
Contributor

I can't speak to the issue at hand, but I am happy to see progress in advancing the spec to a new version. Is there a process to follow?

@glpatcern
Copy link
Member Author

I can't speak to the issue at hand, but I am happy to see progress in advancing the spec to a new version. Is there a process to follow?

Hi @smesterheide, if you have some specific suggestion or RFE you are welcome to file an issue or a PR in GitHub. More in general the CS3 community regularly meets and discusses OCM issues among other topics, and I expect we'll tag a new version of the API at next event.

@glpatcern glpatcern marked this pull request as ready for review December 6, 2022 08:27
@glpatcern
Copy link
Member Author

@michielbdejong @labkode I propose to get this fully sorted out and merged in these days. At least it would reflect what is already (partially) implemented in Reva and in the OC10/NC integrations, as far as I understand.

@glpatcern glpatcern marked this pull request as draft December 8, 2022 06:50
- The /forward endpoint was removed as it's a local call
- The endpoint to notify about an accepted invite is now /invite-accepted
  and it is the only additional endpoint in this PR.
- The response of that endpoint now contains the identity details
  of the sender, which are safe to be disclosed at this point as
  the receiver already did. This allows to address issue cs3org#55.
- A new protocol `webapp` is added to `/NewShare`, to enable opening
  files with remote apps. This removes the need of yet another
  dedicated endpoint.
@glpatcern glpatcern marked this pull request as ready for review December 8, 2022 07:32
@glpatcern
Copy link
Member Author

@michielbdejong and @labkode I've tried to spell out what we brainstormed yesterday (and thanks for the nice discussion!). Please have a look so we can move forward with the necessary changes in Reva.

spec.yaml Show resolved Hide resolved
spec.yaml Show resolved Hide resolved
Copy link
Contributor

@michielbdejong michielbdejong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see you removed the spurious section and the 'name' in OpenAPI 2.0 does not add a level of nesting, so all good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants