-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Invitation workflow for OCM, take 2 #54
Conversation
@glpatcern great, let's have a video call to walk through the details! |
6780049
to
f3b2330
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Self-reviewing for further brainstorming)
I can't speak to the issue at hand, but I am happy to see progress in advancing the spec to a new version. Is there a process to follow? |
Hi @smesterheide, if you have some specific suggestion or RFE you are welcome to file an issue or a PR in GitHub. More in general the CS3 community regularly meets and discusses OCM issues among other topics, and I expect we'll tag a new version of the API at next event. |
@michielbdejong @labkode I propose to get this fully sorted out and merged in these days. At least it would reflect what is already (partially) implemented in Reva and in the OC10/NC integrations, as far as I understand. |
d1580f5
to
6197879
Compare
- The /forward endpoint was removed as it's a local call - The endpoint to notify about an accepted invite is now /invite-accepted and it is the only additional endpoint in this PR. - The response of that endpoint now contains the identity details of the sender, which are safe to be disclosed at this point as the receiver already did. This allows to address issue cs3org#55. - A new protocol `webapp` is added to `/NewShare`, to enable opening files with remote apps. This removes the need of yet another dedicated endpoint.
6197879
to
695e719
Compare
@michielbdejong and @labkode I've tried to spell out what we brainstormed yesterday (and thanks for the nice discussion!). Please have a look so we can move forward with the necessary changes in Reva. |
d991392
to
9fd1f55
Compare
d35cf74
to
47b4508
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see you removed the spurious section and the 'name' in OpenAPI 2.0 does not add a level of nesting, so all good!
This PR supersedes #41.
I have rebased the new endpoints on top of the current
develop
branch. We should have a discussion with @michielbdejong as a main contributor in this repo also to address the yet outstanding comments from the previous PR, so this is still WIP though Reva currently includes a full implementation of these specs.