-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add spaceID to resourceID #174
Conversation
@micbar I agree with @kobergj and @glpatcern that this field MUST be an optional field for time being. |
@micbar @butonic @labkode @glpatcern How about we add a new OPTIONAL |
That surprises me. I thought we have an agreement that spaces are the first class citizens in the API. |
That is what ocis does today and IMO not clean. See the original description of |
@labkode @glpatcern I changed the REQUIRED flag to OPTIONAL. Not a blocker for me. Please let us continue here. |
@micbar I think it's the best option at this point in time, leaving the door open to both approaches. Will merge. |
Description
To correctly address storage spaces in reva, we need another id property on the resourceID.
This change is not breaking and should be compatible for the
master
and theedge
branches.master
branch.We do not need to change anything
edge
branchCurrently the
storageID
attribute is used for a concatenated<storageproviderID>$<spaceID>
With this change, we will be able to separate them and have a clean implementation back.
@labkode @glpatcern I will also update the cs3apis on the master branch to keep everything on the same version of the apis.