Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mockery #58

Merged
merged 2 commits into from
Sep 27, 2024
Merged

Add mockery #58

merged 2 commits into from
Sep 27, 2024

Conversation

jessegeens
Copy link
Contributor

This PR adds a mockery config, and mockery steps in the github workflow, to automatically generate mocked interfaces. This will enable us to do easier unit testing. Currently, only a mock of the GatewayAPIClient has been generated.

This PR introduces a fix to #57

@jessegeens jessegeens self-assigned this Sep 26, 2024
@glpatcern
Copy link
Member

This is awesome, thanks @jessegeens! Do I understand it right that you're committing in one go the step to autogenerate the mocked code and the (current) mocked code itself?

Copy link
Member

@glpatcern glpatcern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually answering my own question the run mockery step is to be moved to a different CI, which will push a commit here (and has the credentials to do so). Will tell you later how ;)

@glpatcern
Copy link
Member

Let's see if the CI works - a priori the generated code could have been pushed by it but it's fine

@glpatcern glpatcern merged commit d50e291 into main Sep 27, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants