fix sharing invite on virtual drive

cs3org · Mar 12, 2024 · 1b42380 · 1b42380
1 parent fc2867f
commit 1b42380
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 1 deletion.
diff --git a/changelog/unreleased/fix-graph-invite-virtual.md b/changelog/unreleased/fix-graph-invite-virtual.md
@@ -0,0 +1,6 @@
+Bugfix: Fix sharing invite on virtual drive
+
+We fixed the issue when sharing of virtual drive with other users was allowed
+
+https://github.com/cs3org/reva/pull/4568 
+https://github.com/owncloud/ocis/issues/8495 
diff --git a/internal/grpc/services/gateway/gateway.go b/internal/grpc/services/gateway/gateway.go
@@ -38,6 +38,7 @@ import (
 const (
  _spaceTypePersonal = "personal"
  _spaceTypeProject = "project"
+ _spaceTypeVirtual = "virtual"
 )
 
 func init() {

diff --git a/internal/grpc/services/gateway/usershareprovider.go b/internal/grpc/services/gateway/usershareprovider.go
@@ -583,7 +583,7 @@ func (s *svc) addShare(ctx context.Context, req *collaboration.CreateShareReques
 
 func (s *svc) addSpaceShare(ctx context.Context, req *collaboration.CreateShareRequest) (*collaboration.CreateShareResponse, error) {
  if refIsSpaceRoot(req.GetResourceInfo().GetId()) &&
- req.GetResourceInfo().GetSpace().GetSpaceType() == _spaceTypePersonal {
+ (req.GetResourceInfo().GetSpace().GetSpaceType() == _spaceTypePersonal || req.GetResourceInfo().GetSpace().GetSpaceType() == _spaceTypeVirtual) {
  return nil, errors.New("gateway: space type is not eligible for sharing")
  }
  // If the share is a denial we call denyGrant instead.