Add public link access via mount-ID:token/relative-path to the scope (#…

…2287)
cs3org · Nov 17, 2021 · 427e944 · 427e944
1 parent 87c8612
commit 427e944
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/changelog/unreleased/public-link-token-scope.md b/changelog/unreleased/public-link-token-scope.md
@@ -0,0 +1,3 @@
+Bugfix: Add public link access via mount-ID:token/relative-path to the scope
+
+https://github.com/cs3org/reva/pull/2287
diff --git a/pkg/auth/scope/publicshare.go b/pkg/auth/scope/publicshare.go
@@ -87,9 +87,11 @@ func publicshareScope(ctx context.Context, scope *authpb.Scope, resource interfa
 }
 
 func checkStorageRef(ctx context.Context, s *link.PublicShare, r *provider.Reference) bool {
-	// r: <resource_id:<storage_id:$storageID opaque_id:$opaqueID> path:$path > >
+	// r: <resource_id:<storage_id:$storageID opaque_id:$opaqueID> >
+	// OR
+	// r: <resource_id:<storage_id:$public-storage-mount-ID opaque_id:$token/$relative-path> >
 	if r.ResourceId != nil && r.Path == "" { // path must be empty
-		return utils.ResourceIDEqual(s.ResourceId, r.GetResourceId())
+		return utils.ResourceIDEqual(s.ResourceId, r.GetResourceId()) || strings.HasPrefix(r.ResourceId.OpaqueId, s.Token)
 	}
 
 	// r: <path:"/public/$token" >