incorporate requested changes

Signed-off-by: Christian Richter <crichter@owncloud.com>
cs3org · Sep 27, 2022 · 45a367a · 45a367a
1 parent 5af4624
commit 45a367a
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 9 deletions.
diff --git a/changelog/unreleased/add-s3ng-metrics.md b/changelog/unreleased/add-s3ng-metrics.md
diff --git a/pkg/storage/fs/s3ng/blobstore/blobstore.go b/pkg/storage/fs/s3ng/blobstore/blobstore.go
@@ -40,7 +40,7 @@ type Blobstore struct {
 	bucket string
 }
 
-// PrometheusAwareReader provides an interface to an prometheus aweare Reader
+// PrometheusAwareReader provides an interface to an prometheus aware Reader
 type PrometheusAwareReader struct {
 	r io.Reader
 	m *prometheus.CounterVec

diff --git a/pkg/storage/fs/s3ng/blobstore/metrics.go b/pkg/storage/fs/s3ng/blobstore/metrics.go
@@ -18,7 +18,10 @@
 
 package blobstore
 
-import "github.com/prometheus/client_golang/prometheus"
+import (
+	"github.com/prometheus/client_golang/prometheus"
+	"go-micro.dev/v4/util/log"
+)
 
 var (
 	// Namespace defines the namespace for the defines metrics.
@@ -50,8 +53,14 @@ func NewMetrics() *Metrics {
 			Help:      "Storage access tx",
 		}, []string{}),
 	}
-	_ = prometheus.Register(m.Rx)
-	_ = prometheus.Register(m.Tx)
+	err := prometheus.Register(m.Rx)
+	if err != nil {
+		log.Errorf("Failed to register prometheus storage rx Counter (%s)", err)
+	}
+	err = prometheus.Register(m.Tx)
+	if err != nil {
+		log.Errorf("Failed to register prometheus storage tx Counter (%s)", err)
+	}
 
 	return m
 }