fix lock tests

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
cs3org · Feb 17, 2022 · 63c0dc9 · 63c0dc9
1 parent 6d58569
commit 63c0dc9
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 5 deletions.
diff --git a/pkg/storage/utils/decomposedfs/node/locks.go b/pkg/storage/utils/decomposedfs/node/locks.go
@@ -22,6 +22,7 @@ import (
 	"context"
 	"encoding/json"
 	"os"
+	"path/filepath"
 
 	provider "github.com/cs3org/go-cs3apis/cs3/storage/provider/v1beta1"
 	types "github.com/cs3org/go-cs3apis/cs3/types/v1beta1"
@@ -34,20 +35,22 @@ import (
 
 // SetLock sets a lock on the node
 func (n *Node) SetLock(ctx context.Context, lock *provider.Lock) error {
+	nodepath := n.LockFilePath()
 	// check existing lock
 	if l, _ := n.ReadLock(ctx); l != nil {
 		lockID, _ := ctxpkg.ContextGetLockID(ctx)
 		if l.LockId != lockID {
 			return errtypes.Locked(l.LockId)
 		}
-		err := os.Remove(n.LockFilePath())
+		err := os.Remove(nodepath)
 		if err != nil {
 			return err
 		}
 	}
 
+	os.MkdirAll(filepath.Dir(nodepath), 0700)
 	// O_EXCL to make open fail when the file already exists
-	f, err := os.OpenFile(n.LockFilePath(), os.O_EXCL|os.O_CREATE|os.O_WRONLY, 0600)
+	f, err := os.OpenFile(nodepath, os.O_EXCL|os.O_CREATE|os.O_WRONLY, 0600)
 	if err != nil {
 		return errors.Wrap(err, "Decomposedfs: could not create lock file")
 	}

diff --git a/pkg/storage/utils/decomposedfs/node/locks_test.go b/pkg/storage/utils/decomposedfs/node/locks_test.go
@@ -45,7 +45,7 @@ var _ = Describe("Node locks", func() {
 		otherUser = &userpb.User{
 			Id: &userpb.UserId{
 				Idp:      "idp",
-				OpaqueId: "foo",
+				OpaqueId: "otheruserid",
 				Type:     userpb.UserType_USER_TYPE_PRIMARY,
 			},
 			Username: "foo",
@@ -68,8 +68,8 @@ var _ = Describe("Node locks", func() {
 			User:   env.Owner.Id,
 			LockId: uuid.New().String(),
 		}
-		n = node.New("spaceid", "tobelockedid", "", "tobelocked", 10, "", env.Owner.Id, env.Lookup)
-		n2 = node.New("spaceid", "neverlockedid", "", "neverlocked", 10, "", env.Owner.Id, env.Lookup)
+		n = node.New("u-s-e-r-id", "tobelockedid", "", "tobelocked", 10, "", env.Owner.Id, env.Lookup)
+		n2 = node.New("u-s-e-r-id", "neverlockedid", "", "neverlocked", 10, "", env.Owner.Id, env.Lookup)
 	})
 
 	AfterEach(func() {