Merge pull request #4865 from 2403905/fix-appnew-brake

Permission denied is now backing the request.
cs3org · Sep 24, 2024 · 9635c6d · 9635c6d
2 parents 21f62e9 + 3792d96
commit 9635c6d
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/changelog/unreleased/fix-app-new-response-add.md b/changelog/unreleased/fix-app-new-response-add.md
@@ -0,0 +1,5 @@
+Bugfix: Better response codes for app new endpoint
+
+We fixed the response codes for the app new endpoint. Permission denied is now backing the request.
+
+https://github.com/cs3org/reva/pull/4865 
diff --git a/internal/http/services/appprovider/appprovider.go b/internal/http/services/appprovider/appprovider.go
@@ -254,6 +254,7 @@ func (s *svc) handleNew(w http.ResponseWriter, r *http.Request) {
  switch createRes.Status.Code {
  case rpc.Code_CODE_PERMISSION_DENIED:
  writeError(w, r, appErrorPermissionDenied, "permission denied to create the file", nil)
+ return
  case rpc.Code_CODE_NOT_FOUND:
  writeError(w, r, appErrorNotFound, "parent container does not exist", nil)
  return