don't send event when result status is not OK (#2621)

Signed-off-by: jkoberg <jkoberg@owncloud.com>
cs3org · Mar 8, 2022 · b235e3d · b235e3d
1 parent e4509f1
commit b235e3d
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 2 deletions.
diff --git a/changelog/unreleased/send-events-only-if-ok.md b/changelog/unreleased/send-events-only-if-ok.md
@@ -0,0 +1,5 @@
+Bugfix: send events only if response code is `OK`
+
+Before events middleware was sending events also when the resulting status code was not `OK`. This is clearly a bug.
+
+https://github.com/cs3org/reva/pull/2621
diff --git a/internal/grpc/interceptors/eventsmiddleware/events.go b/internal/grpc/interceptors/eventsmiddleware/events.go
@@ -26,6 +26,7 @@ import (
 	"google.golang.org/grpc"
 
 	"github.com/asim/go-micro/plugins/events/nats/v4"
+	rpc "github.com/cs3org/go-cs3apis/cs3/rpc/v1beta1"
 	collaboration "github.com/cs3org/go-cs3apis/cs3/sharing/collaboration/v1beta1"
 	"github.com/cs3org/reva/v2/pkg/events"
 	"github.com/cs3org/reva/v2/pkg/events/server"
@@ -58,7 +59,9 @@ func NewUnary(m map[string]interface{}) (grpc.UnaryServerInterceptor, int, error
 		var ev interface{}
 		switch v := res.(type) {
 		case *collaboration.CreateShareResponse:
-			ev = ShareCreated(v)
+			if v.Status.Code == rpc.Code_CODE_OK {
+				ev = ShareCreated(v)
+			}
 		}
 
 		if ev != nil {

diff --git a/pkg/events/example/example.go b/pkg/events/example/example.go
@@ -61,7 +61,7 @@ func Server() {
 
 // Client builds a nats client
 func Client() events.Stream {
-	c, err := server.NewNatsStream(nats.Address("127.0.0.1:4222"), nats.ClusterID("test-cluster"))
+	c, err := server.NewNatsStream(nats.Address("127.0.0.1:9233"), nats.ClusterID("test-cluster"))
 	if err != nil {
 		log.Fatal(err)
 	}