Fix version restore after pp

Co-authored-by: Julian Koberg <jkoberg@owncloud.com> Signed-off-by: Christian Richter <crichter@owncloud.com>
cs3org · May 9, 2023 · ceddb7f · ceddb7f
1 parent afacd4e
commit ceddb7f
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/changelog/unreleased/fix-version-restore-after-pp.md b/changelog/unreleased/fix-version-restore-after-pp.md
@@ -0,0 +1,6 @@
+Bugfix: Restore last version after positive result
+
+We fixed a bug in the copy routine that prevented restoring of a previous version after post-processing (e.g. virus scanning)
+
+https://github.com/cs3org/reva/pull/3867
+https://github.com/owncloud/enterprise/issues/5709
diff --git a/pkg/storage/utils/decomposedfs/upload/upload.go b/pkg/storage/utils/decomposedfs/upload/upload.go
@@ -370,7 +370,7 @@ func (upload *Upload) cleanup(cleanNode, cleanBin, cleanInfo bool) {
 			upload.Node = nil
 		default:
 
-			if err := upload.lu.CopyMetadata(upload.Node.InternalPath(), p, func(attributeName string) bool {
+			if err := upload.lu.CopyMetadata(p, upload.Node.InternalPath(), func(attributeName string) bool {
 				return strings.HasPrefix(attributeName, prefixes.ChecksumPrefix) ||
 					attributeName == prefixes.TypeAttr ||
 					attributeName == prefixes.BlobIDAttr ||