Merge pull request #3888 from butonic/efficient-space-sharing-for-groups

space member changes do not need to fetch all group members
cs3org · May 15, 2023 · e00c55c · e00c55c
2 parents c645070 + b25ef2a
commit e00c55c
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/changelog/unreleased/efficient-space-sharing-for-groups.md b/changelog/unreleased/efficient-space-sharing-for-groups.md
@@ -0,0 +1,5 @@
+Bugfix: We fixed a bug that unnecessarily fetched all members of a group
+
+Adding or removing groups to spaces is now done without retrieving all group members
+
+https://github.com/cs3org/reva/pull/3888
diff --git a/internal/http/services/owncloud/ocs/handlers/apps/sharing/shares/spaces.go b/internal/http/services/owncloud/ocs/handlers/apps/sharing/shares/spaces.go
@@ -61,8 +61,9 @@ func (h *Handler) getGrantee(ctx context.Context, name string) (provider.Grantee
 	log.Debug().Str("name", name).Msg("no user found")
 
 	groupRes, err := client.GetGroupByClaim(ctx, &groupv1beta1.GetGroupByClaimRequest{
-		Claim: "group_name",
-		Value: name,
+		Claim:               "group_name",
+		Value:               name,
+		SkipFetchingMembers: true,
 	})
 	if err == nil && groupRes.Status.Code == rpc.Code_CODE_OK {
 		return provider.Grantee{