Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error handling on the PublicShare manager #1087

Closed
refs opened this issue Aug 13, 2020 · 0 comments · Fixed by #1090
Closed

Fix error handling on the PublicShare manager #1087

refs opened this issue Aug 13, 2020 · 0 comments · Fixed by #1090

Comments

@refs
Copy link
Member

refs commented Aug 13, 2020

context: #1064

When using the json shares manager, it can be the case we found a share with a resource_id that no longer exists. This PR aims to address his case by changing the contract of getPath and return the result of the STAT call instead of a generic error, so we can check the cause.

The same has to be essentially done for the public shares manager.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant