Ignore Stray Public Shares #1090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
3 tasks
PVince81
reviewed
Aug 13, 2020
| if err != nil { | ||
| return nil, err | ||
| if statResponse.Status.Code != rpc.Code_CODE_OK { | ||
| if statResponse.Status.Code == rpc.Code_CODE_NOT_FOUND { |
There was a problem hiding this comment.
is status code is neither or nor not found, should still return nil, err, might need to format that error
PVince81
reviewed
Aug 13, 2020
| @@ -1162,14 +1162,14 @@ func (h *Handler) listPublicShares(r *http.Request, filters []*link.ListPublicSh | |||
| } | |||
|
|
|||
| statResponse, err := c.Stat(ctx, statRequest) | |||
| if err != nil { | |||
There was a problem hiding this comment.
we should keep detecting grpc call errors and returning nil, err
ishank011
approved these changes
Aug 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
context: #1087. Closes #1087
Separated from #1064 to keep changes atomic.