Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use UidNumber and GidNumber fields in the user objects #1516

Closed
ishank011 opened this issue Mar 5, 2021 · 2 comments
Closed

Use UidNumber and GidNumber fields in the user objects #1516

ishank011 opened this issue Mar 5, 2021 · 2 comments
Assignees
Labels
junior-job Easy issues

Comments

@ishank011
Copy link
Contributor

Recently the CS3APIs user object was enhanced with the fields UidNumber and GidNumber. Previously, we used to store these in the opaque map. We need to update all the instances where this happens to use these first-class citizens instead.

@ishank011 ishank011 added the junior-job Easy issues label Mar 5, 2021
@sudo-sturbia
Copy link
Contributor

sudo-sturbia commented Mar 18, 2021

Hi @ishank011! I'd like to do this if it's possible. Just to clarify, should we update where user objects are created or where they are used? Also, should the opaque map be left empty?

@ishank011
Copy link
Contributor Author

Hi @sudo-sturbia! You'll need to update both such instances. The user objects are populated in pkg/auth, where the logged-in user is set in the context, and pkg/user, which providers user resolution methods. So these would need to be updated. And the opaque object might contain other fields which you can just leave be, but these two can be removed.

These methods and objects are utilized by other microservices, especially the ones in the storage layer, so in those pieces of code, you need to read from these fields rather than extract them from the opaque map.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
junior-job Easy issues
Projects
None yet
Development

No branches or pull requests

2 participants