-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add pragmatic favorites implementation #2036
Comments
from gitter:
|
Initial work done here: #2071 |
For enabling favorites in web we need a boolean capability Needs to be defined here: https://github.com/owncloud/ocis/blob/bbcea23e85b705aafee17e0fbf05d67cc961b819/ocs/pkg/service/v0/data/capabilities.go#L79 cc @labkode |
@kulmann does that enables the sidebar "Favourites" only or also the star icon in the row rendering? |
Enables everything related to favorites:
|
The web ui needs an efficient way to list all files that have been marked as favorite by a user. We already persist the faverite flag on a per user basis in the extended attributes when using the decomposedfs. But for querying we need an efficient lookup, similar to the share manager.
Searching by favorite is one case of searching by metadata. While the bigger picture is tracked in #41 and cs3org/cs3apis#8 we propose an intermediate solution.
As discussed in person we propose to introduce a go interface and implementation that the ocdav api can use to implement listing of favorite files. The ocdav service can then persist the favorites using that api, optionally also set them on the storage using extended attributes and read them from the api.
When this is done we can either add a
favorites manager
to the CS3 api or directly work on #41@labkode @ishank011
The text was updated successfully, but these errors were encountered: