Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pragmatic favorites implementation #2036

Closed
butonic opened this issue Sep 3, 2021 · 5 comments
Closed

add pragmatic favorites implementation #2036

butonic opened this issue Sep 3, 2021 · 5 comments

Comments

@butonic
Copy link
Contributor

butonic commented Sep 3, 2021

The web ui needs an efficient way to list all files that have been marked as favorite by a user. We already persist the faverite flag on a per user basis in the extended attributes when using the decomposedfs. But for querying we need an efficient lookup, similar to the share manager.

Searching by favorite is one case of searching by metadata. While the bigger picture is tracked in #41 and cs3org/cs3apis#8 we propose an intermediate solution.

As discussed in person we propose to introduce a go interface and implementation that the ocdav api can use to implement listing of favorite files. The ocdav service can then persist the favorites using that api, optionally also set them on the storage using extended attributes and read them from the api.

When this is done we can either add a favorites manager to the CS3 api or directly work on #41

@labkode @ishank011

@butonic
Copy link
Contributor Author

butonic commented Sep 6, 2021

from gitter:
Hugo Labrador @labkode 10:46

#2036: is what I had in mind, just replicate the model for sharing. We'll need to extend the CS3APIS to provide that functionality. I suggest you start with the "metadata manager" driver and interface
We hook it in the ocdav layer as a workaround and when the CS3APIS plus the GRPC service are ready we port the logic from ocdav to this service

@labkode
Copy link
Member

labkode commented Sep 17, 2021

Initial work done here: #2071

@kulmann
Copy link
Member

kulmann commented Sep 17, 2021

@labkode
Copy link
Member

labkode commented Sep 17, 2021

@kulmann does that enables the sidebar "Favourites" only or also the star icon in the row rendering?

@kulmann
Copy link
Member

kulmann commented Sep 17, 2021

Enables everything related to favorites:

  • nav item in the left sidebar with dedicated favorites view
  • favorites star in the right sidebar
  • context menu (right click) action for toggling favorites

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants