Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EOS GRPC doesn't populate the sys ACL field #2246

Open
ishank011 opened this issue Nov 8, 2021 · 4 comments
Open

EOS GRPC doesn't populate the sys ACL field #2246

ishank011 opened this issue Nov 8, 2021 · 4 comments
Assignees

Comments

@ishank011
Copy link
Contributor

We need something like

sysACL, err := acl.Parse(attrs["sys.acl"], acl.ShortTextForm)
if err != nil {
return nil, err
}

@ffurano
Copy link
Contributor

ffurano commented Nov 9, 2021

Having a look

@ffurano
Copy link
Contributor

ffurano commented Nov 9, 2021

So, it seems to me that you want the ACL field to contain the content of the xattr field "sys.acl" in addition to the "real" ACLs that are returned by EOS/grpc (if any)
Easy to do, yet since this seems strange to me, could you please confirm that I understood right?

@ishank011
Copy link
Contributor Author

Aren't these the "real" ACLs? Using file info you only get this

@ffurano
Copy link
Contributor

ffurano commented Nov 9, 2021

I am not able to catch the subtlety that may lie between this xattr and the response of getacl. Surely if Insert the xattr we save one latency hit.
However I got the message, and it's what I have done

I can't test it by now on eoshomecanary as my key has been removed. Since it's simple stuff, I am opening a MR anyway

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants