Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eosgrpc and HTTP - Small fixes for ACLs and client certs #2252

Merged
merged 9 commits into from
Nov 18, 2021

Conversation

ffurano
Copy link
Contributor

@ffurano ffurano commented Nov 9, 2021

Fulfils:
#2246

@update-docs
Copy link

update-docs bot commented Nov 9, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

Copy link
Contributor

@ishank011 ishank011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add user ACLs if sys.eval.useracl is set. Since EOS doesn't obey sys ACLs for files, we have to set these as user attrs. (This is not merged yet, it's part of this PR #2247)

// Read user ACLs if sys.eval.useracl is set
if userACLEval, ok := attrs["sys."+userACLEvalKey]; ok && userACLEval == "1" {
if userACL, ok := attrs["user.acl"]; ok {
userAcls, err := acl.Parse(userACL, acl.ShortTextForm)
if err != nil {
return nil, err
}
for _, e := range userAcls.Entries {
err = sysACL.SetEntry(e.Type, e.Qualifier, e.Permissions)
if err != nil {
return nil, err
}
}
}
}

@ffurano
Copy link
Contributor Author

ffurano commented Nov 9, 2021

I have added the snippet of ACL logic

@ffurano ffurano changed the title Add the xattr sys.acl to SysACL (eosgrpc) eosgrpc and HTTP - Small fixes for ACLs and client certs Nov 17, 2021
@labkode labkode merged commit 4380948 into cs3org:master Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants