Progress with the eosgrpc client #1154
Conversation
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
ffurano
force-pushed
the
master
branch
2 times, most recently
from
0d11b71
to
35f781b
Compare
|
@ffurano @ishank011 we need to check why the go.mod are changed and why we need a different version of protobuf. |
|
Good point indeed.
The eos grpc interface works only with the "standard" version of protoc. For some
historical reason instead reva was forcing an older version. I had to remove
this (old?) constraint.
Fabrizio
…On 2020-10-06 16:11, Hugo G. Labrador wrote:
@ffurano <https://github.com/ffurano> @ishank011 <https://github.com/ishank011> we need to check why the go.mod are changed and
why we need a different version of protobuf.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#1154 (comment)>, or
unsubscribe <https://github.com/notifications/unsubscribe-auth/ABJBUT4UTFLQS422XXK7ENDSJMQQ5ANCNFSM4RBM4BSA>.
|
|
@ffurano why was the update to eos_grpc.pb.go needed though? I don't think there's any change there except those introduced by the version change. Doesn't it work with the previous one? We won't need to uncomment the downgrade if it works anyway. |
|
If there are no breaking changes, GRPC supports backward compatibility. So even if EOS runs a newer version, requests from a client running an older version should be supported. We need to followup with people from owncloud about when we can revert the downgrade but it should be fine for now. We also need to use an older version in cs3APIs cs3org/cs3apis-build@f1ef147 because of this downgrade, but it's compatible with the newer versions. |
|
Hi,
this is not correct unfortunately, and if you uncomment that line the grpc client will not work anymore.
If reva *really* needs to use a very old version of protoc then it's impossible to keep
the grpc protobuf file in a separate github project. It has to be embedded in reva (which
is what I had done at the beginning)
My personal preference is for the latter (i.e. keeping the .proto file in the reva tree
and compiling it with the same protoc version as other things in reva). This is cheaper
to maintain and quite pragmatic, but does not follow the latest fancy fashions.
So, I'd kindly prompt for a shared decision, as it's not good if one has to comment that line
every time just for running the grpc interface.
Cheers
Fabrizio
…On 2020-10-07 14:56, Ishank Arora wrote:
If there are no breaking changes, GRPC supports backward compatibility. So even if EOS runs a newer version, requests from a
client running an older version should be supported. We need to followup with people from owncloud about when we can revert the
downgrade but it should be fine for now.
We also need to use an older version in cs3APIs ***@***.***
<cs3org/cs3apis-build@f1ef147> because of this downgrade, but it's
compatible with the newer versions.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#1154 (comment)>, or
unsubscribe <https://github.com/notifications/unsubscribe-auth/ABJBUTYICTQQLVJZ4DTI6D3SJRQPHANCNFSM4RBM4BSA>.
|
|
Hi @ffurano, let's unblock this with a common ground. Let's git submodule the the EOS protobuf and we compile inside Reva. |
|
Hi Hugo,
uhm... I don't feel we are blocked on this. I am waiting for
the etag in the stat information from eos.
Or are you referring to other things? Like the protoc version?
f
Il 21/10/20 09:27, Hugo G. Labrador ha scritto:
… Hi @ffurano <https://github.com/ffurano>, let's unblock this with a
common ground. Let's git submodule the the EOS protobuf and we compile
inside Reva.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1154 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABJBUT3FSJBPEFW4PRYCPCDSL2EM3ANCNFSM4RBM4BSA>.
|
ffurano
force-pushed
the
master
branch
2 times, most recently
from
470c077
to
2d0574a
Compare
|
This pull request introduces 4 alerts and fixes 4 when merging 1d0b992 into ee561f9 - view on LGTM.com new alerts:
fixed alerts:
|
|
This pull request introduces 4 alerts and fixes 4 when merging 9191b1e into ee561f9 - view on LGTM.com new alerts:
fixed alerts:
|
|
This pull request introduces 4 alerts and fixes 4 when merging e2debf0 into ee561f9 - view on LGTM.com new alerts:
fixed alerts:
|
| @@ -1507,6 +1448,17 @@ func (fs *eosfs) getRootUIDAndGID(ctx context.Context) (string, string, error) { | |||
| return "0", "0", nil | |||
| } | |||
|
|
|||
| //func attrTypeToString(at eosclient.AttrType) string { | |||
|
And rebase |
|
done
Il 02/12/20 15:11, Ishank Arora ha scritto:
… And rebase
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1154 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABJBUT5TF5PVUSER3CJQOCTSSZDKHANCNFSM4RBM4BSA>.
|
Follows PR cs3org#903
|
This pull request introduces 4 alerts and fixes 4 when merging 3be2ee2 into 783e35c - view on LGTM.com new alerts:
fixed alerts:
|
|
This pull request introduces 4 alerts and fixes 4 when merging 115d36f into e018223 - view on LGTM.com new alerts:
fixed alerts:
|
No description provided.