Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse HTTP Clients #1260

Merged
merged 5 commits into from
Oct 20, 2020
Merged

Reuse HTTP Clients #1260

merged 5 commits into from
Oct 20, 2020

Conversation

refs
Copy link
Member

@refs refs commented Oct 20, 2020

File descriptors on the ocdav service, especially on the put handler was leaking http connections. This PR addresses this.

@refs refs requested a review from labkode as a code owner October 20, 2020 14:28
@update-docs
Copy link

update-docs bot commented Oct 20, 2020

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@ishank011
Copy link
Contributor

ishank011 commented Oct 20, 2020

Thanks a lot for this @refs! I was looking at the storage provider tus methods for the leaks and was pulling my hair. This should be good!

Can you fix the lint? We can merge it then

@refs
Copy link
Member Author

refs commented Oct 20, 2020

Thanks a lot for this @refs! I was looking at the storage provider tus methods for the leaks and was pulling my hair. This should be good!

Can you fix the lint? We can merge it then

haha, goland, too lazy to configure watchers :D on it

@refs
Copy link
Member Author

refs commented Oct 20, 2020

@ishank011 imports should be good now. waiting for checks

@butonic
Copy link
Contributor

butonic commented Oct 20, 2020

datagateway is also leaking ... @refs is adding it to this pr

@butonic
Copy link
Contributor

butonic commented Oct 20, 2020

@ishank011 we should double check all places where the rhttp.GetHttpClient() is called. The context that is passed is not used anyway. So we can initialize the client when starting the services. That will allow reusing connections 🚀

@refs refs changed the title Reuse HTTP Client on ocdav Reuse HTTP Clients Oct 20, 2020
Copy link
Contributor

@ishank011 ishank011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@butonic definitely. I'll get to fixing these next. Thanks!

@ishank011 ishank011 merged commit 86b2550 into cs3org:master Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants