Add a Reva SDK #1280
Merged
Add a Reva SDK #1280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labkode
reviewed
Oct 27, 2020
go.sum
Outdated
| @@ -30,6 +30,8 @@ github.com/Azure/go-ntlmssp v0.0.0-20200615164410-66371956d46c/go.mod h1:chxPXzS | |||
| github.com/BurntSushi/toml v0.3.1 h1:WXkYYl6Yr3qBf1K79EBnL4mak0OimBfB0XUf9Vl28OQ= | |||
| github.com/BurntSushi/toml v0.3.1/go.mod h1:xHWCNGjB5oqiDr8zfno3MHue2Ht5sIBksp03qcyfWMU= | |||
| github.com/BurntSushi/xgb v0.0.0-20160522181843-27f122750802/go.mod h1:IVnqGOEym/WlBOVXweHU+Q+/VP0lqqI8lqeDx9IjBqo= | |||
| github.com/Daniel-WWU-IT/libreva v0.0.0-20201020084352-b17e3e76d0db h1:XQr9TOjKV0gCBQ62OIyZOqYpOYNapqXWyAf9wZBUxiY= | |||
There was a problem hiding this comment.
run go mod tidy to cleanup these deps
labkode
requested changes
Oct 27, 2020
There was a problem hiding this comment.
@Daniel-WWU-IT can you change the license headers to match those of the existing code (Apache, styling) and then you can add your organisation under CERN, in your case WWU.
This development is sponsored under the project.
labkode
approved these changes
Oct 27, 2020
labkode
approved these changes
Oct 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR integrates the libreva directly into Reva as the Reva SDK.
The Reva SDK (located under
/pkg/sdk/) is a simple software development kit to work with Reva through the CS3API. It's goal is to make working with Reva as easy as possible by providing a high-level API which hides all the details of the underlying CS3API. Basically, the SDK puts the Reva CLI code into a reusable library (this also means that the CLI should at some point, when the SDK is more feature-complete, be based on the SDK to avoid code duplication).Documentation and an example are also provided. Note that at this early stage, only a few operations are support (up- & downloads, basic file operations); the functionality will be extended in the future, of course.