fix error type in ReadNode when file was not found #1294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
C0rby
force-pushed
the
fix-error-type-ocis-storage
branch
from
fcfae52
to
2c8bdca
Compare
The method ReadNode in the ocis storage didn't return the error type NotFound when a file was not found. Signed-off-by: David Christofas <dchristofas@owncloud.com>
C0rby
force-pushed
the
fix-error-type-ocis-storage
branch
from
2c8bdca
to
5733e16
Compare
butonic
approved these changes
Nov 3, 2020
|
@ishank011 this should help with owncloud/ocis#755 (comment) in Can you review please? |
ishank011
approved these changes
Nov 4, 2020
|
Thanks @ishank011. 🤟 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method ReadNode in the ocis storage didn't return the error type NotFound when a file was not found.