fix ocis move #1343
Merged
fix ocis move #1343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
butonic
force-pushed
the
fix-ocis-move
branch
from
631cf98
to
f3a6c3d
Compare
kulmann
approved these changes
Nov 28, 2020
There was a problem hiding this comment.
Awesome, this indeed fixes owncloud/ocis#975
Code looks good and I ran it locally with ocis to confirm. Creating folders a and b, then moving b into a the parentid in the extended attributes of b is correct after the move (see screenshot) and I can now upload files into /a/b again. 🚀 💪
labkode
approved these changes
Nov 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the old node id to build the target path for xattr updates.
#1343
owncloud/ocis#975