Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement: calculate and expose actual file permission set #1368

Merged
merged 41 commits into from
Jan 8, 2021
Merged

Enhancement: calculate and expose actual file permission set #1368

merged 41 commits into from
Jan 8, 2021

Commits on Jan 7, 2021

  1. prevent sharing with increased permissions 

    Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
    @butonic
    butonic committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    8e485c2 View commit details
    Browse the repository at this point in the history

  2. refactor permission mapping to a role struct 

    Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
    @butonic
    butonic committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    a0cd57f View commit details
    Browse the repository at this point in the history

  3. stop faking dav permissions 

    Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
    @butonic
    butonic committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    30af05b View commit details
    Browse the repository at this point in the history

  4. make ocis driver calculate permissions 

    Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
    @butonic
    butonic committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    2974e0c View commit details
    Browse the repository at this point in the history

  5. return all permissions when user is owner wherever possible 

    Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
    @butonic
    butonic committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    d0c6fdc View commit details
    Browse the repository at this point in the history

  6. refactor reading and assembling permissions 

    Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
    @butonic
    butonic committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    c8283b0 View commit details
    Browse the repository at this point in the history

  7. fake permissions for share recipients at the driver level 

    Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
    @butonic
    butonic committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    ef0c8f4 View commit details
    Browse the repository at this point in the history

  8. fix permission conversion 

    Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
    @butonic
    butonic committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    8de73c2 View commit details
    Browse the repository at this point in the history

  9. fix lint, less expected failed tests 

    Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
    @butonic
    butonic committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    bedbc4e View commit details
    Browse the repository at this point in the history

  10. less expected failures 

    Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
    @butonic
    butonic committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    7add009 View commit details
    Browse the repository at this point in the history

  11. add changelog 

    Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
    @butonic
    butonic committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    2a5d5b0 View commit details
    Browse the repository at this point in the history

  12. less expected failures 

    Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
    @butonic
    butonic committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    15c657e View commit details
    Browse the repository at this point in the history

  13. cleanup after rebase 

    Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
    @butonic
    butonic committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    cd48234 View commit details
    Browse the repository at this point in the history

  14. enforce public share permissions 

    Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
    @butonic
    butonic committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    11e06d0 View commit details
    Browse the repository at this point in the history

  15. implement files drop 

    Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
    @butonic
    butonic committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    ef6daa5 View commit details
    Browse the repository at this point in the history

  16. file shares never have delete or create permission 

    Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
    @butonic
    butonic committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    8683de2 View commit details
    Browse the repository at this point in the history

  17. fix typo

    @butonic
    butonic committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    5e7afad View commit details
    Browse the repository at this point in the history

  18. files never have a create permission 

    Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
    @butonic
    butonic committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    390604c View commit details
    Browse the repository at this point in the history

  19. differentiate not found vs unauthenticated for link tokens 

    Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
    @butonic
    butonic committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    cf51af0 View commit details
    Browse the repository at this point in the history

  20. not found token should return 403 

    Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
    @butonic
    butonic committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    68875a7 View commit details
    Browse the repository at this point in the history

  21. guard against missing permissionset 

    Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
    @butonic
    butonic committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    997ca40 View commit details
    Browse the repository at this point in the history

  22. differentiate between oc:permissions and ocs:share-permissions 

    Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
    @butonic
    butonic committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    59c9f95 View commit details
    Browse the repository at this point in the history

  23. ace read flag grants GetPath 

    Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
    @butonic
    butonic committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    98e5117 View commit details
    Browse the repository at this point in the history

  24. forward more error types 

    Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
    @butonic
    butonic committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    c3a2fa5 View commit details
    Browse the repository at this point in the history

  25. update expected failures 

    Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
    @butonic
    butonic committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    498fa3f View commit details
    Browse the repository at this point in the history

  26. return missing link target as 404 

    Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
    @butonic
    butonic committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    9500fbc View commit details
    Browse the repository at this point in the history

  27. fix permission check 

    Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
    @butonic
    butonic committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    3fda868 View commit details
    Browse the repository at this point in the history

  28. treat permission denied as 401 

    Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
    @butonic
    butonic committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    f3f558a View commit details
    Browse the repository at this point in the history

  29. update local test configs 

    Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
    @butonic
    butonic committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    392a83f View commit details
    Browse the repository at this point in the history

  30. different default permissions 

    Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
    @butonic
    butonic committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    d85b5b6 View commit details
    Browse the repository at this point in the history

  31. handle file individual share permissions 

    Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
    @butonic
    butonic committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    d6321bc View commit details
    Browse the repository at this point in the history

  32. update unexpected passes 

    Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
    @butonic
    butonic committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    5e8fa19 View commit details
    Browse the repository at this point in the history

  33. Apply suggestions from code review 

    Co-authored-by: Phil Davis <phil@jankaritech.com>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
    @butonic @phil-davis
    butonic and phil-davis committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    7f2ca3a View commit details
    Browse the repository at this point in the history

  34. clarify ocPublicPermToRole 

    Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
    @butonic
    butonic committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    605fb1f View commit details
    Browse the repository at this point in the history

  35. update expected test failures and changelog 

    Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
    @butonic
    butonic committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    92db0fd View commit details
    Browse the repository at this point in the history

  36. parent owner becomes owner of uploaded files 

    Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
    @butonic
    butonic committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    e36dd46 View commit details
    Browse the repository at this point in the history

  37. parent owner becomes owner of new folders 

    Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
    @butonic
    butonic committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    0f14362 View commit details
    Browse the repository at this point in the history

  38. fix home creation 

    Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
    @butonic
    butonic committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    074d616 View commit details
    Browse the repository at this point in the history

  39. update expected failures and changelog 

    Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
    @butonic
    butonic committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    79f82c6 View commit details
    Browse the repository at this point in the history

  40. fix lint 

    Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
    @butonic
    butonic committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    c69f470 View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2021

  1. cleanup permissions rendering for propfind 

    Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
    @butonic
    butonic committed Jan 8, 2021
    Configuration menu
    Copy the full SHA
    c3cbdd1 View commit details
    Browse the repository at this point in the history