initial range request support #1388
Conversation
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
butonic
force-pushed
the
range-header
branch
2 times, most recently
from
9b4676f
to
a381108
Compare
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
|
all green, good to merge! |
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
| /* | ||
| if md.Checksum != "" { | ||
| w.Header().Set("OC-Checksum", md.Checksum) | ||
| } | ||
| */ | ||
| if _, err := io.Copy(w, httpRes.Body); err != nil { | ||
| var c int64 | ||
| if c, err = io.Copy(w, httpRes.Body); err != nil { |
There was a problem hiding this comment.
We should return an error status in this case, right? Currently it would just return OK or partial content if the GET request above didn't return any error. Same for the errors below.
There was a problem hiding this comment.
Actually we can't because the header has already been sent and the Copy is streaming the bytes.
All we can do is log that something went wrong.
There was a problem hiding this comment.
Yes, but if the copy fails, user would still receive a 200 with corrupt file contents.
There was a problem hiding this comment.
correct. even if we would buffer everything into ram ... we cannot change the http header when the body is being sent. The best we can do is log an error.
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
|
Lint needs to be fixed |
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
The desktop client uses range requests to continue downloads. It does not expect the full content / a 200 OK response and would assemble a broken file.
EOS has to download the whole file to the storage provider ... I did not find an option to
xrdcopythat would allow reducing the size. So I left theFS.Download()interface as is. It actually is just anOpen()and should be renamed anyway.deprecates #701
Signed-off-by: Jörn Friedrich Dreyer jfd@butonic.de