Separate blobs from metadata in the ocis driver #1452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
aduffeck
force-pushed
the
streamline-s3ng-and-ocis
branch
7 times, most recently
from
4c17963
to
9f9b1b1
Compare
aduffeck
force-pushed
the
streamline-s3ng-and-ocis
branch
from
9f9b1b1
to
e7116e9
Compare
refs
reviewed
Feb 15, 2021
| } | ||
|
|
||
| // NewDefault returns an instance with default components | ||
| func NewDefault(m map[string]interface{}, bs tree.Blobstore) (storage.FS, error) { |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
aduffeck
force-pushed
the
streamline-s3ng-and-ocis
branch
from
a48811a
to
1d0e7d5
Compare
aduffeck
force-pushed
the
streamline-s3ng-and-ocis
branch
2 times, most recently
from
10d0512
to
0815066
Compare
home and users were already switched byfore.
During upload the content hash is used as the blobID which automagically provides deduplication on the blobstore side.
We currently don't have reference counting for blobs in place so deduplication using the content hash is not yet possible.
Directories don't have blobs associated with them.
aduffeck
force-pushed
the
streamline-s3ng-and-ocis
branch
4 times, most recently
from
c25b29e
to
ecc2efc
Compare
aduffeck
force-pushed
the
streamline-s3ng-and-ocis
branch
from
ecc2efc
to
e7e05fa
Compare
|
@butonic @phil-davis the ldap problem seems to be back unfortunately... (e.g. in https://drone.cernbox.cern.ch/cs3org/reva/710) |
refs
previously approved these changes
Mar 3, 2021
C0rby
reviewed
Mar 3, 2021
aduffeck
force-pushed
the
streamline-s3ng-and-ocis
branch
from
d3f1fa5
to
7bb67e1
Compare
labkode
requested changes
Mar 3, 2021
|
@labkode Thanks for your comment. I renamed the file accordingly. |
butonic
approved these changes
Mar 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr makes the ocis driver store the actual file content separately from the metadata, allowing for using a different (potentially faster) storage for the metadata.
Common code between the
ocisands3ngdrivers is extracted into adecomposedfspackage which leaves them with just a thin layer for the different blobstore implementations.