Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[meshdirectory] New UI frontend with project branding #1505

Merged
merged 7 commits into from
Mar 15, 2021

Conversation

mirekys
Copy link
Member

@mirekys mirekys commented Mar 1, 2021

Replaces the temporary version of web frontend of the mesh directory http service with
a new redesigned & branded one.

Because the new frontend is a more complex Vue SPA that contains image,
css and other assets, it is now served from a binary package distribution that was generated using the
github.com/rakyll/statik package. The http.services.meshdirectory.static
config option will be obsoleted by this change.

@labkode what should be the best place to put the Vue frontend sources into?
Is it ok to create e.g. meshdirectory-web repo under @sciencemesh or @cs3org for it?

Screenshot_2021-02-26 Mesh Directory ScienceMesh

Fixes #1502

@mirekys mirekys requested a review from labkode as a code owner March 1, 2021 08:45
@SamuAlfageme
Copy link
Contributor

@mirekys omg, this is awesome - might I suggest some icons on the footer "Resources" links? Awesome work! 👏

@labkode
Copy link
Member

labkode commented Mar 1, 2021

@mirekys this is really good! We can host it under sciencemesh org. I give you admin perms so you can create the repo.
For the static site generation to embeed the binary, 1.16 has just got support to embeed his natively in case you want to give it a try.

https://golang.org/pkg/embed/

@pferreir
Copy link
Contributor

pferreir commented Mar 1, 2021

Great work, @mirekys! If you just allow me to nitpick on something, that "account." at the bottom looks a bit out of place to me. I would rather reword the text on top to say "using your account at" and leave the bottom part empty.

@mirekys
Copy link
Member Author

mirekys commented Mar 2, 2021

@pferreir @labkode @SamuAlfageme Thanks to all for the tips! Please have a look at meshdirectory-web if I managed to address them all. I also went for embedding the app using the new 'embed'. It works nicely and is a cleaner approach, if there isn't any problem with raising the minimal Go version on reva to 1.16 (CI fails currently because of this).

@labkode
Copy link
Member

labkode commented Mar 12, 2021

@mirekys sorry for late reply. Can you bump the go version in this PR for the CI as well? We should make it green.

@mirekys
Copy link
Member Author

mirekys commented Mar 12, 2021

@labkode bumped go & fixed build, but not sure what causes LGTM to complain about:

[2021-03-12 15:37:42] [build-err] Only found JavaScript or TypeScript files that were empty or contained syntax errors.
[2021-03-12 15:37:42] [ERROR] Spawned process exited abnormally (code 255; tried to run: [/opt/dist/javascript/tools/autobuild.sh])

there are no .js|.ts files touched in this PR

@labkode labkode merged commit 8ca141d into cs3org:master Mar 15, 2021
ffurano pushed a commit to ffurano/reva that referenced this pull request Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mesh Directory UI frontend redesign
4 participants