-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[meshdirectory] New UI frontend with project branding #1505
Conversation
@mirekys omg, this is awesome - might I suggest some icons on the footer "Resources" links? Awesome work! 👏 |
@mirekys this is really good! We can host it under sciencemesh org. I give you admin perms so you can create the repo. |
Great work, @mirekys! If you just allow me to nitpick on something, that "account." at the bottom looks a bit out of place to me. I would rather reword the text on top to say "using your account at" and leave the bottom part empty. |
@pferreir @labkode @SamuAlfageme Thanks to all for the tips! Please have a look at meshdirectory-web if I managed to address them all. I also went for embedding the app using the new 'embed'. It works nicely and is a cleaner approach, if there isn't any problem with raising the minimal Go version on reva to 1.16 (CI fails currently because of this). |
@mirekys sorry for late reply. Can you bump the go version in this PR for the CI as well? We should make it green. |
@labkode bumped go & fixed build, but not sure what causes LGTM to complain about:
there are no .js|.ts files touched in this PR |
Replaces the temporary version of web frontend of the mesh directory http service with
a new redesigned & branded one.
Because the new frontend is a more complex Vue SPA that contains image,
css and other assets, it is now served from a binary package distribution that was generated using the
github.com/rakyll/statik package. The
http.services.meshdirectory.static
config option will be obsoleted by this change.
@labkode what should be the best place to put the Vue frontend sources into?
Is it ok to create e.g.
meshdirectory-web
repo under @sciencemesh or @cs3org for it?Fixes #1502