Add grpc integration tests for the ocis and the owncloud storage drivers #1514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduffeck
force-pushed
the
grpc-tests
branch
3 times, most recently
from
9e5fda7
to
429af59
Compare
aduffeck
changed the title
aduffeck
changed the title
aduffeck
changed the title
butonic
previously approved these changes
Mar 11, 2021
It always works that way in the other direction ("r" -> GetPath)
As defined in the protocol.
butonic
approved these changes
Mar 12, 2021
ishank011
approved these changes
Mar 16, 2021
|
@aduffeck I merged the PR without rebasing, which breaks the expected tests sync, as well introduces some lint issues, sorry about that! Can you create another PR to fix these? Thanks! |
17 tasks
ffurano
pushed a commit
to ffurano/reva
that referenced
this pull request
Apr 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a test suite which tests the grpc interface to the storage provider with the ocis and the owncloud drivers.
It also fixes a few issues found while writing the tests:
GetPathpermission translate to a "r" ace permissionCODE_NOT_FOUNDwhen listing the non-existent shared folder