fix move in the owncloud storage driver #1696
Conversation
C0rby
force-pushed
the
fix-move-owncloud-storage
branch
from
6abb674
to
6b17ec2
Compare
|
Argh... cloning the oc10 tests failed... I don't have permissions to restart the build... |
|
@C0rby how difficult will it be to fix the delete method? Since we're addressing this issue, I'd like for all its occurrences to be fixed because we still have support for the driver in reva. If it'll take too long, then we can skip it |
|
The thing about deleting is that purging non empty folders does not work and purging versions of files doesn't work. I can't really tell how long it will take to fix them. |
| // than the acceptance tests we should be fine by ignoring the errors. | ||
| _ = filepath.Walk(newIP, func(path string, info os.FileInfo, err error) error { | ||
| if err != nil { | ||
| log.Error().Str("path", path).Err(err).Msg("error caching id") |
There was a problem hiding this comment.
Can you add a log about rolling back the whole op? And a TODO comment
There was a problem hiding this comment.
Ok I opened an issue #1699
And added todos.
Update the filepath in redis when moving a file. Didn't implement it in delete since delete is still a bit more broken. But since we don't actively use the owncloud storage driver except for in CI it's not too important. Fixes cs3org#1693
C0rby
force-pushed
the
fix-move-owncloud-storage
branch
from
6b17ec2
to
0529666
Compare
Update the filepath in redis when moving a file. Didn't implement it in delete since delete is still a bit more broken. But since we don't actively use the owncloud storage driver except for in CI it's not too important.
Fixes #1693