set Content-Type correctly #1750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
labkode
previously approved these changes
Jun 1, 2021
|
Thanks for approving , I want to tweak it a bit so that reva responses the same as oC10 |
individual-it
force-pushed
the
fixContentType
branch
from
95c6944
to
06b5f42
Compare
|
@labkode I've added some more changes, please review again |
phil-davis
previously approved these changes
Jun 2, 2021
all headers need to be set before `w.WriteHeader(status code)` is called
individual-it
force-pushed
the
fixContentType
branch
from
06b5f42
to
373e0f3
Compare
phil-davis
approved these changes
Jun 2, 2021
labkode
approved these changes
Jun 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
all headers need to be set before
w.WriteHeader(status code)is calledfixes owncloud/ocis#1779