Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests-Only]Adjust expected failures files #1801

Merged
merged 1 commit into from
Jun 21, 2021

Conversation

jasson99
Copy link
Contributor

Description

This PR adjusts the issues in the expected failures file such that the closed issues are replaced with the existing correct issues.

Related Issue

How Has This Been Tested?

  • CI

@jasson99 jasson99 requested a review from labkode as a code owner June 18, 2021 08:06
@phil-davis phil-davis self-requested a review June 18, 2021 11:20
@phil-davis
Copy link
Contributor

@dpakach @jasson99 when you get the expected-failures sorted out, then please also bump the core commit id to the latest today: 2d62e7370ce3a2b5034d0aa460b3e6ca248b1052

It will be good to have the adjusted test in that commit running in reva CI.

@phil-davis
Copy link
Contributor

@dpakach https://drone.cernbox.cern.ch/cs3org/reva/1847/18/7

runsh: Total unexpected failed scenarios throughout the test run:
apiWebdavProperties1/copyFile.feature:121
apiWebdavProperties1/copyFile.feature:122
apiWebdavProperties1/copyFile.feature:170
apiWebdavProperties1/copyFile.feature:171
apiWebdavUploadTUS/uploadToShare.feature:56
apiWebdavUploadTUS/uploadToShare.feature:57
runsh: Total unexpected passed scenarios throughout the test run:
apiWebdavProperties1/copyFile.feature:117
apiWebdavProperties1/copyFile.feature:118
apiWebdavProperties1/copyFile.feature:351
apiWebdavProperties1/copyFile.feature:352
apiWebdavProperties1/copyFile.feature:371
apiWebdavProperties1/copyFile.feature:372
apiWebdavProperties1/copyFile.feature:396
apiWebdavProperties1/copyFile.feature:397
apiWebdavProperties1/copyFile.feature:423
apiWebdavProperties1/copyFile.feature:424
apiWebdavProperties1/copyFile.feature:449
apiWebdavProperties1/copyFile.feature:450
apiWebdavProperties1/copyFile.feature:475
apiWebdavProperties1/copyFile.feature:476

Looks like a few more edits are needed to expected-failures.

@dpakach dpakach force-pushed the adjustExpectedFailuresIssues branch from f0c590a to 357b4ec Compare June 21, 2021 11:35
@dpakach dpakach force-pushed the adjustExpectedFailuresIssues branch from 357b4ec to 5bb945f Compare June 21, 2021 12:22
@phil-davis
Copy link
Contributor

@ishank011 this will be helpful for PRs like #1795 "fix restore behavior of the trashbin API"

Among other things, a trashbin restore scenario has been adjusted in core to better reflect what should happen.

@labkode labkode merged commit 567ec47 into cs3org:master Jun 21, 2021
@phil-davis phil-davis deleted the adjustExpectedFailuresIssues branch June 21, 2021 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants