Support for Deleting Shared Folders as a Share Receiver

[refs]

closes owncloud/ocis#2148

[update-docs]

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

[lgtm-com]

This pull request introduces 1 alert when merging c12e29f into 089745e - view on LGTM.com

new alerts:

• 1 for Useless assignment to local variable

[butonic]

#nice ❤️

[labkode]

@refs what about putting this logic in the gateway?
If the gateway can catch a Remove request to a share it will call the share manager and set is as decline (not pending, see attached video).

@ishank011 what do you think?

unsharing.mov

[ishank011]

If the gateway can catch a Remove request to a share it will call the share manager and set is as decline (not pending, see attached video)

+1

Instead of calling ListReceivedShares for every delete request, we can instead add that logic here

reva/internal/grpc/services/gateway/storageprovider.go

Lines 850 to 857 in 905fa4c

	if s.isShareName(ctx, p) {
	log.Debug().Msgf("path:%s points to share name", p)
	ref := &provider.Reference{Path: p}
	req.Ref = ref
	return s.delete(ctx, req)
	}

[refs]

@refs what about putting this logic in the gateway?
If the gateway can catch a Remove request to a share it will call the share manager and set is as decline (not pending, see attached video).

@ishank011 what do you think?
unsharing.mov

Agree, that'd save some back and forth 👍 !

[refs]

@labkode decline seems like a more appropriate state for the share. I'll update the PR to reflect it.

[lgtm-com]

This pull request introduces 1 alert when merging 8de3310 into 7df477f - view on LGTM.com

new alerts:

• 1 for Useless assignment to local variable

[refs]

@ishank011, @labkode if this matches the criteria, it should be ready to be merged 🎉

[ishank011]

@refs looks good but I think we can add this parameter to DeleteRequest if we want to skip moving the resource to recycle bin. What do you think? @labkode @butonic