Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Traces: Use OpenTelemetry #1984

Merged
merged 15 commits into from
Aug 17, 2021
Merged

Traces: Use OpenTelemetry #1984

merged 15 commits into from
Aug 17, 2021

Conversation

refs
Copy link
Member

@refs refs commented Aug 11, 2021

What is OpenTelemetry?

  • open standard
  • sandbox CNCF project.
  • formed through a merger of the OpenTracing and OpenCensus.

OpenCensus and OpenTracing have merged to form OpenTelemetry, which serves as the next major version of OpenCensus and OpenTracing. OpenTelemetry will offer backwards compatibility with existing OpenCensus integrations, and we will continue to make security patches to existing OpenCensus libraries for two years.

There is a lot of outdated documentation as a result of this merger, and we think adopting the latest standard and libraries will benefit the project.

@update-docs
Copy link

update-docs bot commented Aug 11, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@refs
Copy link
Member Author

refs commented Aug 16, 2021

@labkode @ishank011 does it make sense I update all traces occurrences that use the go.opencensus.io lib? I see the EOS storage provider binary is rich with traces and metrics, we could tackle that in this PR or in a follow-up one. How does that sound?

There are still a few technicalities to solve, but I'd say this PR is in good track.

@labkode
Copy link
Member

labkode commented Aug 16, 2021

Hi @refs, yes we can take the EOS part later. I think we should go for OT as default.

@refs refs marked this pull request as ready for review August 16, 2021 15:19
@refs refs requested a review from labkode as a code owner August 16, 2021 15:19
@refs
Copy link
Member Author

refs commented Aug 16, 2021

@labkode I think the current state should be ready for review. However I still need to wrap my head around the metrics instrumentation.

This PR should leave the traces in a better state than they currently are.

@refs refs changed the title [WIP] Traces: Use OpenTelemetry Traces: Use OpenTelemetry Aug 17, 2021
@labkode labkode merged commit aaf1fb8 into cs3org:master Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants