Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create exporter based on agent endpoint configuration #2029

Merged
merged 3 commits into from
Sep 3, 2021
Merged

Create exporter based on agent endpoint configuration #2029

merged 3 commits into from
Sep 3, 2021

Conversation

refs
Copy link
Member

@refs refs commented Sep 1, 2021

@refs refs requested a review from labkode as a code owner September 1, 2021 11:30
@update-docs
Copy link

update-docs bot commented Sep 1, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@exalate-issue-sync exalate-issue-sync bot mentioned this pull request Sep 1, 2021
Closed
@lgtm-com
Copy link

lgtm-com bot commented Sep 1, 2021

This pull request introduces 1 alert when merging 39afba6 into b54f42d - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable

@refs refs mentioned this pull request Sep 1, 2021
Merged
@wkloucek wkloucek self-requested a review September 1, 2021 12:52
wkloucek
wkloucek previously approved these changes Sep 1, 2021
View reviewed changes
Copy link
Contributor

@wkloucek wkloucek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with Jaeger agent and works

@micbar
Copy link
Member

micbar commented Sep 1, 2021

needs changelog

@refs
Copy link
Member Author

refs commented Sep 2, 2021

@labkode this should be ready for review + merge

@labkode labkode merged commit 73f10ed into cs3org:master Sep 3, 2021
@micbar micbar mentioned this pull request Sep 15, 2021
Closed
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@labkode labkode labkode approved these changes

@butonic butonic butonic approved these changes

@wkloucek wkloucek wkloucek left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@refs @micbar @butonic @labkode @wkloucek