Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend AppRegistry and AppProvider #2067

Merged
merged 9 commits into from
Sep 23, 2021
Merged

Conversation

glpatcern
Copy link
Member

@glpatcern glpatcern commented Sep 14, 2021

Implementation in Reva of the extensions in cs3org/cs3apis#145.

Some values have to be filled in from config, this will be targeted in a separate PR.

@glpatcern glpatcern self-assigned this Sep 14, 2021
@glpatcern glpatcern marked this pull request as draft September 14, 2021 11:06
@glpatcern glpatcern force-pushed the appreg-mimetypes branch 9 times, most recently from 3f94e84 to a858fb2 Compare September 16, 2021 15:44
@glpatcern glpatcern marked this pull request as ready for review September 16, 2021 15:44
@glpatcern glpatcern force-pushed the appreg-mimetypes branch 4 times, most recently from 61bff26 to ead121a Compare September 17, 2021 12:38
@glpatcern glpatcern force-pushed the appreg-mimetypes branch 4 times, most recently from 0838452 to bfb2969 Compare September 17, 2021 17:06
@glpatcern glpatcern force-pushed the appreg-mimetypes branch 5 times, most recently from 3fddae5 to 076c5bc Compare September 21, 2021 17:12
@glpatcern
Copy link
Member Author

glpatcern commented Sep 21, 2021

@ishank011 this is now (finally) complete. I will test it tomorrow in our QA before giving you green light for merging (can't validate the tests yet as we need to merge the CS3APIs PR first), but it can already be reviewed.

@ishank011
Copy link
Contributor

Merged cs3org/cs3apis#145

@glpatcern glpatcern force-pushed the appreg-mimetypes branch 2 times, most recently from e30836f to 3b2879b Compare September 22, 2021 16:08
@glpatcern glpatcern force-pushed the appreg-mimetypes branch 2 times, most recently from ceb8dfa to bfaf26d Compare September 23, 2021 14:01
@glpatcern glpatcern force-pushed the appreg-mimetypes branch 2 times, most recently from fc5d6df to 3beafc3 Compare September 23, 2021 14:12
@ishank011 ishank011 merged commit eeeecd1 into cs3org:master Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants