-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restrict EOS project spaces sharing permissions to admins #2153
Conversation
@ishank011 we might need to check if the user has the privileges when setting the permissions, but for time being, from the UI this will be hidden, so is good to go for first stage. |
@labkode yes, I check that at least one of these has to be set when executing this code
The issue is that EOS never really sets the 'm' permission, so the permission's never set for any directory that isn't owned by the user. As a workaround, I'm adding a check that if 'w' and 'x' are set, we allow resharing as well. Does that sound okay? |
c8e391e
to
04745b2
Compare
Instead of this, I inverted the check and I'm setting the sharing permissions to true for the admins group |
fe99a6b
to
c85b55b
Compare
No description provided.