Reply to share actions with full path #2177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
diocas
force-pushed
the
fix_sharing
branch
2 times, most recently
from
3a4874c
to
a1c7710
Compare
labkode
reviewed
Oct 21, 2021
internal/http/services/owncloud/ocs/handlers/apps/sharing/shares/shares.go
Outdated
Show resolved
Hide resolved
Change order when deciding whether to keep full paths
ishank011
previously approved these changes
Oct 25, 2021
refs
previously approved these changes
Oct 25, 2021
|
IIRC Codacy caches the filename with underscore, for whatever reason. We've had the same at owncloud. IMO this is good to be merged. There was a fix but I don't exactly remember which was it, perhaps squashing and force pushing forces codacy to pull the new filename, or deleting the file and committing a new one (with the same name and contents) 😄 |
refs
approved these changes
Oct 25, 2021
ishank011
approved these changes
Oct 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When accessing "shared with others" or when accepting a share in "shared with me" (from the web), the replies all come without the full path, which we need to properly redirect the user.
So I've made these full paths in the backend. This is a first attempt, from someone who knows little about this code, so I need the tests to see what else I broke. If you have suggestions, let me know.
This was discussed and fixed in the past, but I guess this particular case was forgotten.
I already see some strange things (I think):
Pathgets again converted to trimmed path due to thisstorage_id: "shared::/eos/user/etc/etc/etc"