Modify group and user managers to skip fetching specified metadata #2205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labkode
previously approved these changes
Oct 26, 2021
ishank011
force-pushed
the
fetch-groups-members-config
branch
from
3f152fb
to
21f1b59
Compare
labkode
previously approved these changes
Oct 26, 2021
labkode
previously approved these changes
Oct 28, 2021
refs
previously approved these changes
Oct 29, 2021
dragotin
reviewed
Oct 29, 2021
ishank011
force-pushed
the
fetch-groups-members-config
branch
from
d1a050a
to
785a24c
Compare
labkode
previously approved these changes
Nov 18, 2021
ishank011
force-pushed
the
fetch-groups-members-config
branch
from
faa8ae3
to
dccc5a4
Compare
ishank011
force-pushed
the
fetch-groups-members-config
branch
from
dccc5a4
to
c6e6293
Compare
labkode
approved these changes
Feb 7, 2022
|
LGTM I think it makes sense to omit fetching members if they are not needed. While I don't see a problem with this PR @rhafer may have a deeper understanding of the user and group relationships. I currently cannot review this PR and 'accept' it because github gives me a 500 ... 😞 |
rhafer
pushed a commit
to rhafer/reva
that referenced
this pull request
Mar 22, 2022
…s3org#2205) (cherry picked from commit 9e040c9)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.