Enforce permissions in public share apps #2214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
C0rby
force-pushed
the
fix-public-wopi
branch
from
f1bba51
to
c330b23
Compare
refs
previously approved these changes
Oct 28, 2021
C0rby
force-pushed
the
fix-public-wopi
branch
3 times, most recently
from
bf04eac
to
06275ce
Compare
refs
previously approved these changes
Oct 29, 2021
This was referenced Nov 2, 2021
ishank011
reviewed
Nov 10, 2021
internal/grpc/services/publicstorageprovider/publicstorageprovider.go
Outdated
Show resolved
Hide resolved
C0rby
force-pushed
the
fix-public-wopi
branch
from
06275ce
to
5c23a16
Compare
C0rby
force-pushed
the
fix-public-wopi
branch
2 times, most recently
from
0ce9c57
to
acc1d7b
Compare
ishank011
reviewed
Nov 11, 2021
internal/grpc/services/publicstorageprovider/publicstorageprovider.go
Outdated
Show resolved
Hide resolved
C0rby
force-pushed
the
fix-public-wopi
branch
from
acc1d7b
to
0e63784
Compare
ishank011
previously approved these changes
Nov 11, 2021
ishank011
reviewed
Nov 11, 2021
internal/grpc/services/publicstorageprovider/publicstorageprovider.go
Outdated
Show resolved
Hide resolved
C0rby
force-pushed
the
fix-public-wopi
branch
from
0e63784
to
63e8935
Compare
C0rby
force-pushed
the
fix-public-wopi
branch
from
63e8935
to
d027b16
Compare
ishank011
approved these changes
Nov 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A receiver of a read-only public share could still edit files via apps like Collabora.
These changes enforce the share permissions in apps used on publicly shared resources.