Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aggregrate resource info properties for virtual views #2215

Merged
merged 2 commits into from
Oct 28, 2021

Conversation

ishank011
Copy link
Contributor

No description provided.

@labkode labkode merged commit 80b2065 into cs3org:master Oct 28, 2021
@ishank011 ishank011 deleted the eos-virtual-views branch October 28, 2021 12:02
@C0rby
Copy link
Contributor

C0rby commented Oct 29, 2021

What are virtual views? I'm currently rebasing #2016 and don't want to break this.

@ishank011
Copy link
Contributor Author

@C0rby When listing / and let's say we have two providers mounted at /reva/users and /reva/projects, both should return /reva (after aggregrating the metrics of the underlying resources) and these should in turn be aggregrated in the gateway. Another use case which would need a lot of workarounds with #2016.

@butonic
Copy link
Contributor

butonic commented Oct 29, 2021

But that mixes concerns even further! The registry is responsible for the mount points. If no storage provider is mounted at / or at /reva then you cannot list those paths. Period. They don't exist. In https://github.com/cs3org/reva/pull/2023/files#diff-0d2961654453acb28ab32bc57e437cd52492efd9c76e2db3b49864e6322081a6R685 the gateway would learn how to calculate the etag for storage providers embedded via multiple path segments.

If you want to be able to navigate into /reva mount a storage provider with the eos driver that is configured to show the /reva dir.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants