Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix share permission on a file in sql (cbox pkg) share driver #2231

Merged
merged 2 commits into from
Nov 3, 2021

Conversation

gmgigi96
Copy link
Member

@gmgigi96 gmgigi96 commented Nov 3, 2021

While creating a share permission with write permission, the cbox/sql share driver converted this to a permission value that corresponds to a viewer role. This PR fix this.

@update-docs
Copy link

update-docs bot commented Nov 3, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

Copy link
Contributor

@ishank011 ishank011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice debugging!

@ishank011 ishank011 merged commit a21af87 into cs3org:master Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants