Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove the base64 encoding of fileIDs #2559

Merged
merged 1 commit into from
Feb 17, 2022
Merged

Conversation

micbar
Copy link
Member

@micbar micbar commented Feb 17, 2022

Description

Backport of #2542

@micbar
Copy link
Member Author

micbar commented Feb 17, 2022

@labkode @ishank011 I think this is an important backport from the edge branch.

Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

There are no changes to https://github.com/cs3org/reva/blob/master/pkg/storage/utils/decomposedfs/spaces.go

I guess those changes in edge branch are not relevant here in master?

@micbar
Copy link
Member Author

micbar commented Feb 17, 2022

I guess those changes in edge branch are not relevant here in master?

Yes, correct.

@micbar micbar requested a review from butonic February 17, 2022 08:42
@micbar
Copy link
Member Author

micbar commented Feb 17, 2022

@ishank011 @labkode This could break your bookmarked URLs of the bookmarks and the ID lookup of the app provider.

You decide, if you need this in master. Reva edge has it already.

@labkode labkode merged commit 289beae into cs3org:master Feb 17, 2022
@micbar micbar mentioned this pull request May 5, 2022
45 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants