Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix space shares and storage ids #2802

Merged
merged 6 commits into from
May 2, 2022
Merged

Conversation

micbar
Copy link
Member

@micbar micbar commented Apr 30, 2022

Description

Revert of #2787

@ishank011 @butonic I needed to revert #2787 because I observed intermittent failures in the oCIS CI. The errors were a bit random, the share listing and the share responses were somehow inconsistent. I was not able to reproduce these issues locally. So that led me to the assumption that these issues were introduced by concurrency problems.

I would like to revive #2787 as soon as possible and make it reliable.

@micbar micbar requested a review from phil-davis May 1, 2022 10:08
@cs3org cs3org deleted a comment from update-docs bot May 1, 2022
@micbar micbar marked this pull request as ready for review May 1, 2022 10:12
@micbar micbar requested review from labkode, ishank011, glpatcern and a team as code owners May 1, 2022 10:12
@micbar micbar requested a review from dragotin May 1, 2022 10:13
@sonarcloud
Copy link

sonarcloud bot commented May 2, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 247 Code Smells

No Coverage information No Coverage information
8.9% 8.9% Duplication

@micbar micbar merged commit 8bcec2e into cs3org:edge May 2, 2022
@micbar micbar mentioned this pull request May 5, 2022
45 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants