Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix version #2876

Merged
merged 3 commits into from
May 17, 2022
Merged

Fix version #2876

merged 3 commits into from
May 17, 2022

Conversation

micbar
Copy link
Member

@micbar micbar commented May 16, 2022

Bugfix: Fix version number in status page

We needed to undo the version number changes on the status page to keep compatibility for legacy clients. We added a new field productversion for the actual version of the product.

@micbar micbar requested review from a team, labkode, ishank011 and glpatcern as code owners May 16, 2022 11:38
@micbar micbar requested review from dragotin, butonic and wkloucek May 16, 2022 11:39
@micbar micbar mentioned this pull request May 16, 2022
Merged
9 tasks
@phil-davis
Copy link
Contributor

https://drone.cernbox.cern.ch/cs3org/reva/7151/19/7
also needs to go in the S3NG expected-failures.

@phil-davis
Copy link
Contributor

@micbar PR #2878 was merged. So a rebase is needed here, and the status.php test should now pass with these changes. The test allows the status response to have extra fields, and only checks for the minimum required fields that have to match with oC10 behavior.

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 258 Code Smells

No Coverage information No Coverage information
7.1% 7.1% Duplication

@phil-davis
Copy link
Contributor

https://drone.cernbox.cern.ch/cs3org/reva/7162/11/6
Various test fails in cs3api-validator-S3NG. I will restart CI.

@phil-davis
Copy link
Contributor

@micbar drone CI passed. There is just the SonarCloud complaints.

Merge?

@micbar micbar merged commit 690fb7f into cs3org:edge May 17, 2022
@micbar micbar mentioned this pull request May 25, 2022
Closed
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kobergj kobergj kobergj approved these changes

@labkode labkode labkode approved these changes

@phil-davis phil-davis phil-davis approved these changes

@ishank011 ishank011 Awaiting requested review from ishank011

@glpatcern glpatcern Awaiting requested review from glpatcern glpatcern is a code owner

@dragotin dragotin Awaiting requested review from dragotin

@butonic butonic Awaiting requested review from butonic

@wkloucek wkloucek Awaiting requested review from wkloucek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@micbar @phil-davis @labkode @kobergj