Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci]Update expected to fail file master #2917

Merged
merged 1 commit into from
Jun 7, 2022
Merged

[tests-only][full-ci]Update expected to fail file master #2917

merged 1 commit into from
Jun 7, 2022

Conversation

SwikritiT
Copy link
Contributor

@SwikritiT SwikritiT commented Jun 2, 2022 •
edited
Loading

@SwikritiT SwikritiT mentioned this pull request Jun 3, 2022
Closed
11 tasks
@SwikritiT SwikritiT force-pushed the update-expected-to-fail-file-master branch from fe3376c to d53013a Compare June 3, 2022 10:59
@kiranparajuli589 kiranparajuli589 mentioned this pull request Jun 6, 2022
Closed
14 tasks
@SwikritiT SwikritiT force-pushed the update-expected-to-fail-file-master branch from d53013a to 9f17986 Compare June 6, 2022 11:28
@sonarcloud
Copy link

sonarcloud bot commented Jun 6, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@SwikritiT SwikritiT marked this pull request as ready for review June 7, 2022 03:43
@phil-davis phil-davis self-requested a review June 7, 2022 03:43
phil-davis
phil-davis approved these changes Jun 7, 2022
View reviewed changes
Copy link
Contributor

@phil-davis phil-davis left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable. There are some items marked "ToDo". But it will be easier to get this merged now (and similar changes for edge #2910 ). And then we can continue going through expected-failures and looking at diffs between reva master, reva edge and oCIS, and documenting carefully what is the current real issue with each test that fails.

@phil-davis
Copy link
Contributor

@labkode @ishank011 I can't merge this because it touched .drone.star

We are going through expected-failures and gradually getting it to have more up-to-date details about what fails for which issue. So this is a work-in-progress, but it would be nice to merge what we have so far - that way CI will run with it.

Please merge for us.

@ishank011 ishank011 merged commit 6bdce62 into cs3org:master Jun 7, 2022
@phil-davis phil-davis deleted the update-expected-to-fail-file-master branch June 7, 2022 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishank011 ishank011 ishank011 approved these changes

@phil-davis phil-davis phil-davis approved these changes

@labkode labkode Awaiting requested review from labkode

@glpatcern glpatcern Awaiting requested review from glpatcern glpatcern is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SwikritiT @phil-davis @ishank011