Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only] Allow plugin bamarni/composer-bin-plugin #3063

Merged
merged 5 commits into from
Jul 12, 2022
Merged

[tests-only] Allow plugin bamarni/composer-bin-plugin #3063

merged 5 commits into from
Jul 12, 2022

Conversation

SwikritiT
Copy link
Contributor

@SwikritiT SwikritiT commented Jul 11, 2022 •
edited by phil-davis
Loading

Part of issue: Bump bamarni/composer-bin-plugin (1.7.0) owncloud/QA#749

And issue owncloud/QA#748

@SwikritiT SwikritiT changed the title Allow plugin bamarni/composer-bin-plugin [tests-only] Allow plugin bamarni/composer-bin-plugin Jul 11, 2022
@labkode
Copy link
Member

labkode commented Jul 11, 2022

@SwikritiT remember to uncomment this one to see the effect:
https://github.com/cs3org/reva/pull/3061/files

@cs3org cs3org deleted a comment from update-docs bot Jul 11, 2022
@SwikritiT
Copy link
Contributor Author

@SwikritiT remember to uncomment this one to see the effect: https://github.com/cs3org/reva/pull/3061/files

done in latest commit!

@SwikritiT SwikritiT marked this pull request as ready for review July 11, 2022 12:39
phil-davis
phil-davis previously approved these changes Jul 11, 2022
View reviewed changes
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved if CI passes

@phil-davis phil-davis self-assigned this Jul 11, 2022
@SwikritiT SwikritiT requested review from glpatcern and a team as code owners July 11, 2022 15:02
@phil-davis
Copy link
Contributor 

+ composer --version
Composer version 2.0.6 2020-11-07 11:21:17

IMO we need a newer composer in CI.

@phil-davis phil-davis mentioned this pull request Jul 11, 2022
Closed
@phil-davis
Copy link
Contributor

@labkode @ishank011 the new composer-bin-plugin 1.7.0 requires an up-to-date composer.
composer self-update works for here.
It would be nice to have the latest composer 2.3.9 already in the docker images that are being used, but that can happen separately.

Please review.

@phil-davis phil-davis mentioned this pull request Jul 12, 2022
Closed
16 tasks
@labkode labkode merged commit dace224 into cs3org:master Jul 12, 2022
@labkode
Copy link
Member

labkode commented Jul 12, 2022

@phil-davis thanks, note @ishank011 has left CERN.

@phil-davis phil-davis deleted the composer-bin-plugin-1.7.0 branch July 12, 2022 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@labkode labkode labkode approved these changes

@phil-davis phil-davis phil-davis approved these changes

@ishank011 ishank011 Awaiting requested review from ishank011

@glpatcern glpatcern Awaiting requested review from glpatcern glpatcern is a code owner

Assignees

@phil-davis phil-davis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SwikritiT @labkode @phil-davis